Use Unicode Escape Sequence to replace encoded characters#2814
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Aug 26, 2023
Merged
Use Unicode Escape Sequence to replace encoded characters#2814ggerganov merged 1 commit intoggml-org:masterfrom
ggerganov merged 1 commit intoggml-org:masterfrom
Conversation
The use of special characters within source files can break compiling on some computers with different region and language settings. Using Unicode escape sequences should allow for the code to be compiled on all setups without needing to change your computers settings or switch regions.
cebtenzzre
reviewed
Aug 26, 2023
klosax
approved these changes
Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using special characters within source files can break compiling on some computers with different regions and language settings. I have a ja-JP Windows 11 setup, and trying to compile the current master branch fails on
find_bpe_rankdue to the special characters recently introduced. Note that using a compiled build is fine; only compiling itself fails.Using Unicode escape sequences should allow the code to be compiled on all setups without changing your computer's settings or switching regions. Trying out my changes and it seems like everything processes as it should, but hopefully others with more C++ experience know if I screwed something else up here.
e. Searching through the other repos, similar techniques have been done before, so I'm feeling more confident now in this.